chore: standardize repository config#786
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy failed
📋 Build log (last lines)🤖 Powered by surge-preview |
|||||||||
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough将构建、文档、示例与 GitHub 自动化配置切换到 Changes包与构建配置更新
文档与示例迁移
GitHub 自动化更新
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no issues. 🎉 Reviewed by React Doctor for commit |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the repository to use the scoped package name @rc-component/util, updates documentation, and refactors build, deployment, and configuration files (including Dumi, TypeScript, and GitHub Actions). Feedback suggests using __dirname for robust path resolution and removing redundant wildcard aliases in .dumirc.ts. Additionally, it is recommended not to ignore the entire .dumi directory in .gitignore to avoid untracking important configuration and theme files.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 39 39
Lines 1068 1068
Branches 388 380 -8
=======================================
Hits 923 923
Misses 143 143
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/react-component-ci.yml:
- Around line 14-15: The reusable workflow invocation in the CI workflow is too
permissive and uses a mutable reference. Update the workflow call in the rc-test
reuse block to pass only the required secrets explicitly instead of using
secrets: inherit, and change the workflow reference from `@main` to a pinned
commit SHA to match the other fixed action references.
In `@docs/examples/portal.tsx`:
- Line 2: The example in PortalWrapper import is invalid because the module path
and default export do not exist; update the import in portal.tsx to use the
actual Portal component export instead. Use the Portal/PortalWrapper reference
in this example file to locate the statement, and change it to import from the
Portal module or the package’s main entry so the demo resolves correctly.
In `@README.md`:
- Around line 37-41: The Usage example imports `raf` and `Portal` from deep
paths even though the API guidance recommends using the public entry point;
update the example to import both from `@rc-component/util` via the main export
path. Keep any deep-path import examples only for symbols that are not
re-exported from the main entry, and make sure the README example matches the
export structure exposed by `src/index.ts`.
- Around line 59-60: README 的 React utilities 总览与示例中的 Portal 公开 API 不一致，需要统一。请检查
`PortalWrapper` 和 `Portal` 的实际导出关系：如果 `PortalWrapper` 是公开接口，就在 README 的 React
utilities 表格中补充它或注明子路径导入方式；如果标准接口应为 `Portal`，则同步更新 `docs/examples/portal.tsx`
中的使用方式并移除对 `PortalWrapper` 的依赖，确保文档与示例一致。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2fd6df3d-b712-40f3-9050-ef98f9f962d2
📒 Files selected for processing (19)
.dumirc.ts.github/FUNDING.yml.github/dependabot.yml.github/workflows/codeql.yml.github/workflows/react-component-ci.yml.github/workflows/react-doctor.yml.github/workflows/site-deploy.yml.github/workflows/surge-preview.yml.gitignoreREADME.mddocs/examples/dynaymicCSS.tsxdocs/examples/getScrollBarSize.tsxdocs/examples/portal.tsxdocs/examples/styleChecker.tsxdocs/examples/toArray.tsxdocs/index.mdpackage.jsontsconfig.jsonvercel.json
💤 Files with no reviewable changes (1)
- .github/workflows/site-deploy.yml
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/examples/portal.tsx (1)
8-10: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value移除遗留的调试
console.logeffect。该 effect 使用空依赖数组，仅在挂载时执行一次；此时
container仍为null，Portal尚未渲染，divRef.current始终为null，因此该日志没有实际意义，疑似遗留的调试代码。♻️ 建议移除
- React.useEffect(() => { - console.log('>>>', divRef.current); - }, []); - React.useEffect(() => { const element = document.createElement('div');🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/examples/portal.tsx` around lines 8 - 10, Remove the leftover debug effect in Portal by deleting the React.useEffect that logs divRef.current with an empty dependency array; the effect in portal.tsx is not useful because divRef.current stays null on mount before Portal renders. Keep the Portal/divRef setup intact and ensure no console.log debug code remains in this component.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/react-component-ci.yml:
- Around line 14-15: The reusable workflow invocation currently inherits all
secrets, but it only needs CODECOV_TOKEN; update the workflow call in the CI
config by replacing secrets: inherit with an explicit secrets mapping for
CODECOV_TOKEN, using the existing secrets reference, so the called test-utoo.yml
workflow receives only the required credential.
---
Nitpick comments:
In `@docs/examples/portal.tsx`:
- Around line 8-10: Remove the leftover debug effect in Portal by deleting the
React.useEffect that logs divRef.current with an empty dependency array; the
effect in portal.tsx is not useful because divRef.current stays null on mount
before Portal renders. Keep the Portal/divRef setup intact and ensure no
console.log debug code remains in this component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 47aa181d-1510-4ad3-a324-22d34e3ab7c1
📒 Files selected for processing (7)
.dumirc.ts.github/workflows/react-component-ci.yml.github/workflows/surge-preview.yml.gitignoreREADME.mddocs/examples/portal.tsxdocs/examples/toArray.tsx
💤 Files with no reviewable changes (1)
- .gitignore
🚧 Files skipped from review as they are similar to previous changes (3)
- .github/workflows/surge-preview.yml
- README.md
- docs/examples/toArray.tsx
|
Deployment failed with the following error: Learn More: https://vercel.com/react-component?upgradeToPro=build-rate-limit |
|
Deployment failed with the following error: Learn More: https://vercel.com/afc163s-projects?upgradeToPro=build-rate-limit |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/surge-preview.yml (1)
33-34: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win把依赖安装也挂到
enabled条件下。当
SURGE_TOKEN缺失时，Line 36 和 Line 39 都已经跳过了，但 Line 33 仍会执行完整的npm install。对 fork PR 来说这一步通常没有产出，只会增加 CI 时间和网络开销。♻️ 建议修改
- name: Install dependencies + if: ${{ steps.surge-token.outputs.enabled == 'true' }} run: npm install --legacy-peer-deps --ignore-scripts --no-audit --loglevel=warn🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/surge-preview.yml around lines 33 - 34, The dependency installation step still runs even when SURGE_TOKEN is missing, so gate the “Install dependencies” step in surge-preview.yml behind the same enabled condition used by the later surge steps. Update the workflow so the npm install step only executes when the preview is actually enabled, using the existing enabled logic/variable in this job to keep fork PRs from doing unnecessary work.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 54-76: `package.json` 里的依赖已经提升了运行时要求，但还没有显式的 Node 版本约束；请在
`package.json` 中补上与 `@types/node`, `cross-env`, `glob`, `lint-staged` 等兼容的
`engines.node`，并同步检查 CI/`setup-node` 的版本声明，确保本地与流水线都使用同一最低 Node 版本。
---
Nitpick comments:
In @.github/workflows/surge-preview.yml:
- Around line 33-34: The dependency installation step still runs even when
SURGE_TOKEN is missing, so gate the “Install dependencies” step in
surge-preview.yml behind the same enabled condition used by the later surge
steps. Update the workflow so the npm install step only executes when the
preview is actually enabled, using the existing enabled logic/variable in this
job to keep fork PRs from doing unnecessary work.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d52ece8a-7fe6-4fbe-972c-a919825afe16
📒 Files selected for processing (8)
.dumirc.ts.github/workflows/codeql.yml.github/workflows/surge-preview.ymlREADME.mdREADME.zh-CN.mddocs/examples/portal.tsxpackage.jsontsconfig.json
💤 Files with no reviewable changes (1)
- docs/examples/portal.tsx
✅ Files skipped from review due to trivial changes (3)
- README.zh-CN.md
- .dumirc.ts
- README.md
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/codeql.yml
- tsconfig.json
1 participant
Summary
Standardize this rc-component repository as part of the Ant Design rc-component maintenance sweep.
Tracking issue: ant-design/ant-design#58514
Scope
types: "./es/index.d.ts", publishConfig, and release flow through@rc-component/np.react-component/rc-test/.github/workflows/test-utoo.yml@mainworkflow, React Doctor, Codecov, CodeQL, updated GitHub Actions versions, and guarded Surge preview fallback.docs-distoutput and remove legacynow-build/ Cloudflare Pages residue.Notes
secrets: inheritis kept untilreact-component/rc-test#176is merged, then it can be narrowed to explicitCODECOV_TOKENforwarding.